Disable URL connection caching in SPIClassIterator #88586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHegarty
added
:Core/Infra/Plugins
ChrisHegarty
changed the title
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @ChrisHegarty, I've created a changelog YAML for you. |
gmarouli
pushed a commit
to gmarouli/elasticsearch
that referenced
this pull request
Jul 21, 2022
arteam
pushed a commit
to arteam/elasticsearch
that referenced
this pull request
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables URLConnection caching in SPIClassIterator - similar to what j.u.ServiceLoader does.
Resources accessed in jar file, through the URLConnection API, cache by default. In terms of JarURLConnections, this means retaining an open handle to the underlying jar file. This open handle is problematic when attempting to delete the jar file, on Windows. Disabling the jar file cache, for the URLConnections in SPIClassLoader should not negatively affect performance in any substantial way - since there are just a few service configuration files per jar.
The "workaround" here, disabling the cache per JAR URLConnection, is very common, and a consequence of the longstanding behaviour of the JarURLConnection API, as well as the URLClassLoader API.
closes #88275